I sometimes come across vintage suitcases that are in terrific condition, and that is a rarity. I have purchased some. They are an unlikely place for storage. My vintage trailer is one place I use a few. I keep some clothes and shoes in my trailer, and these work very well. There have been rare occasion's when a mouse gets inside...and these are a good idea to keep mice out of my stuff.
I found one of these blue Travel Joy mid-size suitcases that a thrift store, ($5), it is in great condition. My current plan is to store my boots in it during the off season, and during the winter put my sandals in it...in the house...under the bed.